This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add tab completion for TUI's "focus" command
- From: Doug Evans <dje at google dot com>
- To: Patrick Palka <patrick at parcs dot ath dot cx>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Wed, 24 Jun 2015 09:35:15 -0500
- Subject: Re: [PATCH] Add tab completion for TUI's "focus" command
- Authentication-results: sourceware.org; auth=none
- References: <1434943800-9274-1-git-send-email-patrick at parcs dot ath dot cx> <1435073391-18518-1-git-send-email-patrick at parcs dot ath dot cx>
On Tue, Jun 23, 2015 at 10:29 AM, Patrick Palka <patrick@parcs.ath.cx> wrote:
> The implementation is pretty straightforward, with the only caveat being
> that the "src", "cmd", "next" and "prev" entries get delibrately added
> to the completion list even when the TUI has not yet been initialized
> (i.e. has never been enabled during the session), since invoking the
> "focus" command with these arguments already works when the TUI has not
> yet been initialized.
>
> gdb/ChangeLog:
>
> * tui/tui-win.c (focus_completer): New static function.
> (_initialize_tui_win): Set the completion function of the
> "focus" command to focus_completer.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.base/completion.exp: Test the completion of the "focus"
> command.
LGTM