This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Several regressions and we branch soon.
- From: Patrick Palka <patrick at parcs dot ath dot cx>
- To: Doug Evans <dje at google dot com>
- Cc: Keith Seitz <keiths at redhat dot com>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Tue, 23 Jun 2015 17:45:02 -0400 (EDT)
- Subject: Re: Several regressions and we branch soon.
- Authentication-results: sourceware.org; auth=none
- References: <CADPb22SYnN52pqR+1UtR_Vr-1Yxzmx=OyMgnCD-OMcCL1GwAYg at mail dot gmail dot com> <CA+C-WL_uZdNj29-6u4MnqH-8zQt9Q20fzUb6b9nWHKJPCstY9A at mail dot gmail dot com> <CADPb22Rg2FySdxWo9VKb5WApPh-wdf946po9UXX-+kQ99bULug at mail dot gmail dot com> <5589BECB dot 7090200 at redhat dot com> <CADPb22RbcoyxPwwTTQCjSTdexN-D-gfWPd6doF2KbcMm074XyA at mail dot gmail dot com>
On Tue, 23 Jun 2015, Doug Evans wrote:
On Tue, Jun 23, 2015 at 3:17 PM, Keith Seitz <keiths@redhat.com> wrote:
FWIW, I updated my virgin sandbox earlier, and I don't see a bunch of
the failures that you are/have. I've listed the ones I do see below.
FWIW, I have another branch that was last updated the first week of May
which shows none of these problems.
I'll start looking at these failures immediately.
Keith
On 06/23/2015 12:03 PM, Doug Evans wrote:
FAIL: gdb.base/default.exp: info set
FAIL: gdb.base/default.exp: show
The problem here seems to be that the "show" function corresponding to
the "mpx bound" command calls error("Intel(R) Memory Protection
Extensions not supported on this target."); which throws an exception
that causes the entire "info set"/"show" loop to exit early. Should
"show foo" ever throw an exception? Should the "info set"/"show" loop
expect an exception to be thrown from a show function?
This diff fixes the default.exp FAILs as far as I can tell:
diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c
index 42d0346..d11efa1 100644
--- a/gdb/i386-tdep.c
+++ b/gdb/i386-tdep.c
@@ -8777,11 +8777,17 @@ i386_mpx_info_bounds (char *args, int from_tty)
struct type *data_ptr_type = builtin_type (gdbarch)->builtin_data_ptr;
if (!i386_mpx_enabled ())
- error (_("Intel(R) Memory Protection Extensions not\
- supported on this target."));
+ {
+ printf_unfiltered (_("Intel(R) Memory Protection Extensions not "
+ "supported on this target.\n"));
+ return;
+ }
if (args == NULL)
- error (_("Address of pointer variable expected."));
+ {
+ printf_unfiltered (_("Address of pointer variable expected.\n"));
+ return;
+ }
addr = parse_and_eval_address (args);
@@ -8856,7 +8862,7 @@ static struct cmd_list_element *mpx_set_cmdlist, *mpx_show_cmdlist;
static void
set_mpx_cmd (char *args, int from_tty)
{
- help_list (mpx_set_cmdlist, "set mpx", all_commands, gdb_stdout);
+ help_list (mpx_set_cmdlist, "set mpx ", all_commands, gdb_stdout);
}
/* Helper function for the CLI commands. */
@@ -8901,7 +8907,7 @@ is \"default\"."),
add_prefix_cmd ("mpx", class_support, set_mpx_cmd, _("\
Set Intel(R) Memory Protection Extensions specific variables."),
- &mpx_set_cmdlist, "set tdesc ",
+ &mpx_set_cmdlist, "set mpx ",
0 /* allow-unknown */, &setlist);
/* Add "mpx" prefix for the show commands. */