This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 6/7] remote: consider addressable unit size when reading/writing memory
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Wed, 17 Jun 2015 12:55:45 +0100
- Subject: Re: [PATCH v2 6/7] remote: consider addressable unit size when reading/writing memory
- Authentication-results: sourceware.org; auth=none
- References: <1429127258-1033-1-git-send-email-simon dot marchi at ericsson dot com> <1429127258-1033-7-git-send-email-simon dot marchi at ericsson dot com> <555E1A50 dot 7020007 at redhat dot com> <557F274A dot 3060908 at ericsson dot com>
On 06/15/2015 08:28 PM, Simon Marchi wrote:
>>> -> $m1000,8#??
>>> <- aaaabbbbccccdddd
>>>
>>> -> $M1000,6:eeeeffffeeee#??
>>> <- OK
>>>
>>> -> $m1000,8#??
>>> <- eeeeffffeeeedddd
>>>
>
> Ok, I put the example in the comment of remote_write_bytes_aux and added
> a reference to it in remote_read_bytes_1. Do you have a more suitable place
> in mind where to put it?
Nope, that sounds good.
> Thanks for the review. Here's what's new:
>
> * needs_escaping: Added newline and comment.
> * remote_escape_output: Add missing space.
> * remote_write_bytes_aux: Send length in addressable units, update comment with example gdb/stub exchange.
> * remote_read_bytes_1: Same, and update function comment (add UNIT_SIZE).
Looks good to me.
Thanks,
Pedro Alves