This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/4] windows-nat: Replace __COPY_CONTEXT_SIZE conditional with __CYGWIN__
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jon Turney <jon dot turney at dronecode dot org dot uk>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 9 Jun 2015 14:55:05 -0400
- Subject: Re: [PATCH 2/4] windows-nat: Replace __COPY_CONTEXT_SIZE conditional with __CYGWIN__
- Authentication-results: sourceware.org; auth=none
- References: <1433352592-9728-1-git-send-email-jon dot turney at dronecode dot org dot uk> <1433352592-9728-4-git-send-email-jon dot turney at dronecode dot org dot uk>
> Replace __COPY_CONTEXT_SIZE conditional with __CYGWIN__
>
> __COPY_CONTEXT_SIZE was added to Cygwin's headers in 2006.
>
> Versions of Cygwin which don't define __COPY_CONTEXT_SIZE are long obsolete.
>
> Also see the thread starting at
> https://sourceware.org/ml/gdb-patches/2015-03/msg00989.html for some discussion
>
> Note that __COPY_CONTEXT_SIZE should just be sizeof(CONTEXT) (which is a
> platform constant), but isn't due to historical mistakes in Cygwin headers.
>
> gdb/ChangeLog:
>
> 2015-06-03 Jon Turney <jon.turney@dronecode.org.uk>
>
> * windows-nat.c (do_windows_fetch_inferior_registers)
> (handle_output_debug_string): Replace __COPY_CONTEXT_SIZE
> conditional with __CYGWIN__.
FWIW, I don't mind this patch, but I don't necessarily see what
we are gaining from it. Can you explain?
Thanks,
--
Joel