This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] Tweak the handling of $GDBHISTSIZE edge cases [PR gdb/16999]
- From: Pedro Alves <palves at redhat dot com>
- To: Patrick Palka <patrick at parcs dot ath dot cx>, gdb-patches at sourceware dot org
- Date: Fri, 29 May 2015 10:32:22 +0100
- Subject: Re: [PATCH 2/2] Tweak the handling of $GDBHISTSIZE edge cases [PR gdb/16999]
- Authentication-results: sourceware.org; auth=none
- References: <1432293831-23599-1-git-send-email-patrick at parcs dot ath dot cx> <1432293831-23599-2-git-send-email-patrick at parcs dot ath dot cx>
On 05/22/2015 12:23 PM, Patrick Palka wrote:
> + while (isspace (*tmpenv))
> + tmpenv++;
...
> +
> + while (isspace (*endptr))
> + endptr++;
Use skip_spaces/skip_spaces_const for these.
Otherwise looks good to me.
(I suspect that testing the interaction between setting
the history both from a .gdbinit and $GDBHISTSIZE would
call for merging the gdbhistsize-history.exp / gdbinit-history.exp
to a single file.)
Thanks,
Pedro Alves