This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH users/roland/osabi-assert] Do not crash on unrecognized GNU .note.ABI-tag values
- From: Roland McGrath <mcgrathr at google dot com>
- To: GDB <gdb-patches at sourceware dot org>
- Date: Thu, 28 May 2015 17:21:32 -0700
- Subject: [PATCH users/roland/osabi-assert] Do not crash on unrecognized GNU .note.ABI-tag values
- Authentication-results: sourceware.org; auth=none
Diagnosis of unexpected input (in this case, in an executable file)
should not crash as if it were a bug in GDB. This one is especially
harmless, since the "osabi" has so little effect on anything.
OK for trunk and 7.9 branch?
Thanks,
Roland
gdb/
2015-05-28 Roland McGrath <mcgrathr@google.com>
* osabi.c (generic_elf_osabi_sniff_abi_tag_sections): Use warning
rather than internal_error for an unrecognized value.
diff --git a/gdb/osabi.c b/gdb/osabi.c
index 9d90c55..abf4bd4 100644
--- a/gdb/osabi.c
+++ b/gdb/osabi.c
@@ -493,10 +493,9 @@ generic_elf_osabi_sniff_abi_tag_sections (bfd
*abfd, asection *sect, void *obj)
break;
default:
- internal_error (__FILE__, __LINE__,
- _("generic_elf_osabi_sniff_abi_tag_sections: "
- "unknown OS number %d"),
- abi_tag);
+ warning ("GNU ABI tag value %u unrecognized.\n", abi_tag);
+ *osabi = GDB_OSABI_UNKNOWN;
+ break;
}
return;
}