This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Fix ASAN crash for gdb.compile/compile.exp
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 19 May 2015 12:46:53 +0100
- Subject: Re: [patch] Fix ASAN crash for gdb.compile/compile.exp
- Authentication-results: sourceware.org; auth=none
- References: <20150418170138 dot GA9123 at host1 dot jankratochvil dot net>
Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Hi Jan,
I didn't follow the compile work in GDB very much, so I may ask
something wrong or discussed before.
> Whether the objfile really should be already freed during
> call_function_by_hand_dummy() I am not sure.
Is there any reason we release OBJFILE in the dummy frame dtor? Why
don't we register a cleanup to release in OBJFILE in compile_object_run?
together with releasing compile_module? 'struct compile_module' has a
field objfile, which should be released together with
'struct compile_module' instead of dummy_frame.
--
Yao (éå)