This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/7] Remove linux_proc_pid_get_ns
- From: Gary Benson <gbenson at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Fri, 17 Apr 2015 14:44:30 +0100
- Subject: Re: [PATCH 4/7] Remove linux_proc_pid_get_ns
- Authentication-results: sourceware.org; auth=none
- References: <1429186791-6867-1-git-send-email-gbenson at redhat dot com> <1429186791-6867-5-git-send-email-gbenson at redhat dot com> <CADPb22Sa3tNMQjAK=UV0UXBtBZG+qoYU7h6e20tr3HdC=Lj4Gg at mail dot gmail dot com>
Doug Evans wrote:
> On Thu, Apr 16, 2015 at 5:19 AM, Gary Benson <gbenson@redhat.com> wrote:
> > This commit removes linux_proc_pid_get_ns, and updates its only
> > use to use linux_ns_same instead.
> >
> > gdb/ChangeLog:
> >
> > * linux-thread-db.c (nat/linux-namespaces.h): New include.
> > (check_pid_namespace_match): Use linux_ns_same rather than
> > linux_proc_pid_get_ns to spot PID namespace mismatches.
> > * nat/linux-procfs.h (linux_proc_pid_get_ns): Remove.
> > * nat/linux-procfs.c (linux_proc_pid_get_ns): Likewise.
>
> LGTM.
> one nit below
[snip]
> I see we're using pid_t here.
> I think we talked before about a type for pids.
> Since this is all linux specific code maybe use pid_t more in this
> patch set?
I could do that. It would likely only be in linux-namespaces.[ch]
and maybe one or two places in linux-nat.c, all the other stuff is
in the target vectors.
Cheers,
Gary
--
http://gbenson.net/