This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 12/18] Implement completion limiting for sim_command_completer.

From: Mike Frysinger <vapier at gentoo dot org>
To: Keith Seitz <keiths at redhat dot com>
Cc: gdb-patches at sourceware dot org
Date: Tue, 14 Apr 2015 11:28:37 -0400
Subject: Re: [PATCH 12/18] Implement completion limiting for sim_command_completer.
Authentication-results: sourceware.org; auth=none
References: <20150413192235 dot 29172 dot 13097 dot stgit at valrhona dot uglyboxes dot com> <20150413192331 dot 29172 dot 23243 dot stgit at valrhona dot uglyboxes dot com>

On 13 Apr 2015 12:23, Keith Seitz wrote:
> This patch converts sim_command_completer to use maybe_add_completion.

i think you want to push this down into sim/common/sim-options.c ?  otherwise 
you do all of this work only to throw away a good amount of it.

> It does not add any tests, since the `sim' command is highly
> target-dependent and unimplemented for the majority of simulators.

erm, the majority of simulators now have testsuites.  but that doesn't really 
matter because you're updating the gdb part of the API, not the sim side.
-mike

Attachment: signature.asc
Description: Digital signature

References:
- [PATCH 00/18] Implement full completer limiting
  - From: Keith Seitz
- [PATCH 12/18] Implement completion limiting for sim_command_completer.
  - From: Keith Seitz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]