Re: [PATCH] Introduce new shared function remote_fileio_to_fio_error

[Gary Benson <gbenson at redhat dot com>]

Pedro Alves wrote:
> On 04/09/2015 11:50 AM, Gary Benson wrote:
> > Pedro Alves wrote:
> > > On 04/09/2015 10:51 AM, Gary Benson wrote:
> > > > This commit introduces a new shared function to replace three
> > > > identical functions in various places in the codebase.
> > > >
> > > > Ok to commit?
> > >
> > > This is OK, but I think the "remote" in the name is really wrong.
> > > This is converting a _host_ errno to a fileio error.  I think the
> > > function name should reflect that, and not mention remote at all.
> > 
> > Yeah, I kind of thought this when I was writing the patch, but I
> > was also thinking about other things :)
> > 
> > I'm happy to make another patch to rename common-remote-fileio.*
> > to common-fileio.* and rename the functions accordingly.
> 
> I'd prefer even dropping the "common" from the file name.
> host-fileio.* for example would indicate what the file actually does.

Or just fileio.*.

> > Should I push this one first and then make a second, or would you
> > like the rename first and an updated version of this patch second?
> > I'd prefer the former (less work for me!) but I can do the latter
> > if you want it that way.
> 
> Yeah, push what you have first.

I pushed it.  Will mail the renaming patch soon.

Cheers,
Gary

-- 
http://gbenson.net/