This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Fix gdb crash when trying to print the address of a synthetic pointer.


Trying to print the address of a synthetic pointer (such as a C++ reference after O3 optimization) will cause gdb to crash with the following message:

../gdb/dwarf2loc.c:1625: internal-error: Should not be able to create a lazy value with an enclosing type

This patch fixes that by doing a check for synthetic pointers in value_addr and printing an error message.

I have a company-wide copyright assignment. I don't have commit access, though, so it would be great if anyone could commit this for me.

gdb/
2015-04-07 Martin Galvan <martin.galvan@tallertechnologies.com>

	* valops.c (value_addr): Don't try to get the address of a synthetic pointer.

---
 gdb/valops.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gdb/valops.c b/gdb/valops.c
index 66c63c1..66e2c9d 100644
--- a/gdb/valops.c
+++ b/gdb/valops.c
@@ -1474,6 +1474,13 @@ value_addr (struct value *arg1)
   struct value *arg2;
   struct type *type = check_typedef (value_type (arg1));

+  if (value_bits_synthetic_pointer(arg1, value_embedded_offset (arg1),
+      TARGET_CHAR_BIT * TYPE_LENGTH (type)))
+    {
+      error (_("Attempt to take address of a synthetic pointer."));
+      return NULL;
+    }
+
   if (TYPE_CODE (type) == TYPE_CODE_REF)
     {
       /* Copy the value, but change the type from (T&) to (T*).  We
--
2.3.5


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]