This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] fix lib/pascal.exp dest snafu
- From: Doug Evans <xdje42 at gmail dot com>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 6 Apr 2015 08:49:24 -0700
- Subject: Re: [PATCH] fix lib/pascal.exp dest snafu
- Authentication-results: sourceware.org; auth=none
- References: <m3d25hj7jz dot fsf at sspiff dot org> <54db3bc4 dot a2ac440a dot 5576 dot 1b7bSMTPIN_ADDED_BROKEN at mx dot google dot com>
On Wed, Feb 11, 2015 at 3:21 AM, Pierre Muller
<pierre.muller@ics-cnrs.unistra.fr> wrote:
> Hi Doug,
>
>> -----Message d'origine-----
>> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
>> owner@sourceware.org] De la part de Doug Evans
>> Envoyà : mercredi 11 fÃvrier 2015 07:18
>> Ã : gdb-patches@sourceware.org; pierre.muller@ics-cnrs.unistra.fr
>> Objet : [PATCH] fix lib/pascal.exp dest snafu
>>
>> The "dest" parameter to fpc_compile/gpc_compile is the name of
>> compilation destination file, not a board name.
>>
>> This patch fixes this by using names consistent with
>> lib/future.exp:gdb_default_target_compile.
>
> Thank you very much for finding out this
> horrible mistake.
>
> Patch approved,
>
> Pierre Muller
> as pascal language maintainer.
>
>> 2015-02-10 Doug Evans <xdje42@gmail.com>
>>
>> * lib/pascal.exp (gpc_compile): Rename dest arg to destfile.
>> Fix dest parameter to board_info.
>> (fpc_compile): Ditto.
>> (gdb_compile_pascal): Rename dest arg to destfile.
Committed.