This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 03/23/2015 06:31 AM, Joel Brobecker wrote:
LGTM. A few minor comments, but otherwise pre-approved.+++ b/gdb/linespec.h @@ -152,4 +152,8 @@ extern struct symtabs_and_lines decode_line_with_current_source (char *, int); extern struct symtabs_and_lines decode_line_with_last_displayed (char *, int); +/* Does P represent one of the keywords? If so, return + the keyword. If not, return NULL. */ + +extern const char *linespec_lexer_lex_keyword (const char *p);You already have the function documented in linespec.c, so no need to duplicate it here.
Bah. I forgot all about that. It's been a hectic Monday. I'll push a patch to remove this very soon.
+gdb_test "break thread 123" "Unknown thread 123\."I think that "\." should be "\\.", no? Likewise for the expected output of the remaining tests.
Yes, indeed! Thank you for the review, Joel. Keith
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |