This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3 10/14] sim/erc32: Add support for LEON3 processor emulation.


On 05 Mar 2015 09:49, Joel Brobecker wrote:
> > > +    return(memory_read(addr, data, sz, ws));
> > 
> > return isn't a func, so it shouldn't be written like one:
> > 	return memory_read(...);
> 
> Small formatting nit: space before the '(' in function calls...

i was letting that one go here because the current code ignores that in most 
places.  but yeah, that would also be nice to fix.
-mike

Attachment: signature.asc
Description: Digital signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]