This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] Fast tracepoint for powerpc64le

On 02/20/2015 06:04 PM, Wei-cheng Wang wrote:
> +/* Return the value of register REGNUM.  RAW_REGS is collected buffer
> +   by jump pad.  This function is called by emit_reg.  */
> +
> +ULONGEST __attribute__ ((visibility("default"), used))
> +gdb_agent_get_raw_reg (const unsigned char *raw_regs, int regnum)
> +{
> +  if (regnum >= PPC_NUM_FT_COLLECT_GREGS)

Meanwhile several C++ patches landed which changed how this
function should be declared.  Please make this:

 gdb_agent_get_raw_reg (const unsigned char *raw_regs, int regnum)

I think it'd be good to split out the changes that make
ppc gdbserver do Z0 packets too.

(nit: it'd make it easier to identify the different patches in
the series if they had different subjects, which identified their
actual contents.  That's ideal for the subjects of the git commits
too, so best do that when submitting the patches already.)

Thanks for working on this!

Pedro Alves

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]