This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v3 08/14] sim/erc32: Access memory subsystem through struct memsys.

From: Mike Frysinger <vapier at gentoo dot org>
To: Jiri Gaisler <jiri at gaisler dot se>
Cc: gdb-patches at sourceware dot org
Date: Sun, 1 Mar 2015 20:20:39 -0500
Subject: Re: [PATCH v3 08/14] sim/erc32: Access memory subsystem through struct memsys.
Authentication-results: sourceware.org; auth=none
References: <1425244244-27709-1-git-send-email-jiri at gaisler dot se> <1425244244-27709-9-git-send-email-jiri at gaisler dot se>

On 01 Mar 2015 22:10, Jiri Gaisler wrote:
> --- a/sim/erc32/erc32.c
> +++ b/sim/erc32/erc32.c
>  
> -int dumbio = 0; /* normal, smart, terminal oriented IO by default */
> -int tty_setup = 1; /* default setup if not a tty */
> +static int tty_setup = 1; /* default setup if not a tty */

you just added this in patch 7.  shouldn't you squash this change into that ?  
as well as some of these other uart changes ?
-mike

Attachment: signature.asc
Description: Digital signature

References:
- [PATCH v3 00/14] Update of the SPARC SIS simulator
  - From: Jiri Gaisler
- [PATCH v3 08/14] sim/erc32: Access memory subsystem through struct memsys.
  - From: Jiri Gaisler

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]