This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patchv2] compile: Fix GNU-IFUNC funcs called from injected code
- From: Pedro Alves <palves at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>, gdb-patches at sourceware dot org
- Cc: Phil Muldoon <pmuldoon at redhat dot com>
- Date: Thu, 26 Feb 2015 15:49:48 +0000
- Subject: Re: [patchv2] compile: Fix GNU-IFUNC funcs called from injected code
- Authentication-results: sourceware.org; auth=none
- References: <20150224190720 dot GA32497 at host1 dot jankratochvil dot net> <20150224200237 dot GA1746 at host1 dot jankratochvil dot net>
On 02/24/2015 08:02 PM, Jan Kratochvil wrote:
>
> gdb/ChangeLog
> 2015-02-24 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * compile/compile-c-symbols.c (convert_one_symbol, convert_symbol_bmsym)
> (gcc_symbol_address): Call gnu_ifunc_resolve_addr.
Looks good to me too. OK.
I think we could probably avoid the extra infcall done
within gnu_ifunc_resolve_addr if we're going to be running
the generated code anyway, but it's not worth the effort
at this point.
> +if { [prepare_for_testing ${testfile}.exp "$testfile-debug" $srcfile] } {
> + return -1
> +}
> +
> +if ![runto_main] {
> + return -1
> +}
> +
Could you move these inside the prefix too, so that if they
fail for some reason, we get distinct test messages from
the nodebug case?
> +with_test_prefix "debug" {
Thanks,
Pedro Alves