This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] aarch64: correct a size of struct elf_prstatus
- From: AKASHI Takahiro <takahiro dot akashi at linaro dot org>
- To: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, Will Deacon <will dot deacon at arm dot com>, dsaxena at linaro dot org, Yufeng Zhang <yufeng dot zhang at arm dot com>
- Date: Mon, 23 Feb 2015 23:54:11 +0900
- Subject: Re: [PATCH] aarch64: correct a size of struct elf_prstatus
- Authentication-results: sourceware.org; auth=none
- References: <1424653681-18053-1-git-send-email-takahiro dot akashi at linaro dot org> <CAFqB+PyL8Tkpg7+ykpPGezn5odmBqji9F-94xyRtisE9Yh_DsQ at mail dot gmail dot com>
Hi
On 02/23/2015 05:52 PM, Marcus Shawcroft wrote:
On 23 February 2015 at 01:08, AKASHI Takahiro
<takahiro.akashi@linaro.org> wrote:
Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
---
bfd/elf64-aarch64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Hi, I'm confused about which tree / branch this patch is intended for.
The file elf64-aarch64.c was replaced with elfxx-aarch64.c and
elfnn-aarch64.c back in 2013 with this commit:
2013-06-26 Yufeng Zhang <yufeng.zhang@arm.com>
* Makefile.am (BFD64_BACKENDS): Add elfxx-aarch64.c.
I didn't know this. I checked only v7.6, which is a base version
of linaro's gdb, and found a wrong value there, so ...
I will contact our toolchain team.
Thanks,
-Takahiro AKASHI
diff --git a/bfd/elf64-aarch64.c b/bfd/elf64-aarch64.c
index 94d90c5..0454a18 100644
--- a/bfd/elf64-aarch64.c
+++ b/bfd/elf64-aarch64.c
@@ -1529,7 +1529,7 @@ elf64_aarch64_grok_prstatus (bfd *abfd, Elf_Internal_Note *note)
default:
return FALSE;
- case 408: /* sizeof(struct elf_prstatus) on Linux/arm64. */
+ case 392: /* sizeof(struct elf_prstatus) on Linux/arm64. */
/* pr_cursig */
elf_tdata (abfd)->core->signal
= bfd_get_16 (abfd, note->descdata + 12);
The identical patch was applied to the tree in late 2013 by Matt Leach:
+2013-11-12 Matthew Leach <Matthew.Leach@arm.comm>
+
+ * elfxx-aarch64.c (_bfd_aarch64_elf_grok_prstatus): Fix hard-coded
+ size of struct elf_prstatus.
+
- case 408: /* sizeof(struct elf_prstatus) on
Linux/arm64. */
+ case 392: /* sizeof(struct elf_prstatus) on
Linux/arm64. */
Cheers
/Marcus