This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 19 Feb 2015 23:31, Jiri Gaisler wrote: > + * Leon2 emulation, based on leon3.c . no space before the . > +/* The control space devices */ GNU style is to put periods at the end and then two spaces: /* The control space devices. */ you'll need to fix in the whole file > +static int tty_setup = 1; /* default setup if not a tty */ prefer to avoid inline comments especially when they aren't needed like here > +#define APBEND 0x80000100 the defines mix a lot of spaces and tabs. you shouldn't have a space before a tab. > +static void > +init_sim() all these should be (void) > +static void > +error_mode(pc) > + uint32 pc; > +{ please fix old style function prototypes > +struct memsys leon2 = { const ? -mike
Attachment:
signature.asc
Description: Digital signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |