This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Asynchronously resize the TUI
- From: Pedro Alves <palves at redhat dot com>
- To: Patrick Palka <patrick at parcs dot ath dot cx>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 19 Feb 2015 11:00:16 +0000
- Subject: Re: [PATCH] Asynchronously resize the TUI
- Authentication-results: sourceware.org; auth=none
- References: <1424219777-12138-1-git-send-email-patrick at parcs dot ath dot cx> <54E4629A dot 5050400 at redhat dot com> <CA+C-WL9zh2KyViH8Hxf6G=9AuppfYGNYeaWHLBc8KiBiPj4Xwg at mail dot gmail dot com>
On 02/19/2015 12:03 AM, Patrick Palka wrote:
> Thanks for reviewing. I have committed the patch in two pieces
> because I forgot to add the gdb/ChangeLog entry in the first commit.
> Sorry about that...
No worries.
> BTW shouldn't the object returned by create_async_signal_handler() be
> eventually deallocated via delete_async_event_handler() at some point?
> It doesn't seem that we do this for any async signal handler
> currently in use so far..
Yeah, that's not really different from all the global objects that
are allocated on the heap, and aren't ever deleted. They'll just go away
when GDB exits along with the heap. For a proper GDB-as-a-library use
case though, we'd/we'll probably need to consider this.
Thanks,
Pedro Alves