This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/5] Remove struct main_type.vptr_{fieldno,basetype}: TYPE_SPECIFIC_SELF_TYPE
- From: Doug Evans <xdje42 at gmail dot com>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 10 Feb 2015 22:28:40 -0800
- Subject: Re: [PATCH 4/5] Remove struct main_type.vptr_{fieldno,basetype}: TYPE_SPECIFIC_SELF_TYPE
- Authentication-results: sourceware.org; auth=none
- References: <m3twze8kxc dot fsf at sspiff dot org> <54d3aa6b dot a23d460a dot 0d37 dot 0908SMTPIN_ADDED_BROKEN at mx dot google dot com> <m3iofdjpav dot fsf at sspiff dot org> <54d7775a dot 2b2c460a dot 5b38 dot 7725SMTPIN_ADDED_BROKEN at mx dot google dot com>
On Sun, Feb 8, 2015 at 6:48 AM, Pierre Muller
<pierre.muller@ics-cnrs.unistra.fr> wrote:
>> Here's a patch.
>> You're patch is on the right track, TYPE_SPECIFIC_FIELD can
>> legitimately be TYPE_SPECIFIC_NONE if the field hasn't been initialized
>> yet. I like the patch below as it's more general.
>
> I agree with you that this patch seems
> much secure, as it allows to use TYPE_SELF_TYPE as
> a test as before.
>
>
>> 2015-02-07 Doug Evans <xdje42@gmail.com>
>>
>> * gdbtypes.c (internal_type_self_type): If TYPE_SPECIFIC_FIELD
>> hasn't
>> been initialized yet, return NULL.
Committed.