This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Merge GCC producer parsers. Allow digits in identifiers.

From: Mark Wielaard <mjw at redhat dot com>
To: Patrick Palka <patrick at parcs dot ath dot cx>
Cc: Joel Brobecker <brobecker at adacore dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
Date: Wed, 11 Feb 2015 00:50:58 +0100
Subject: Re: [PATCH] Merge GCC producer parsers. Allow digits in identifiers.
Authentication-results: sourceware.org; auth=none
References: <1422185341-20243-1-git-send-email-mjw at redhat dot com> <20150129080018 dot GH5193 at adacore dot com> <1422535409 dot 4947 dot 5 dot camel at bordewijk dot wildebeest dot org> <1423070384 dot 4947 dot 47 dot camel at bordewijk dot wildebeest dot org> <20150204180550 dot GC4738 at adacore dot com> <1423079956 dot 4947 dot 52 dot camel at bordewijk dot wildebeest dot org> <1423600163 dot 4947 dot 86 dot camel at bordewijk dot wildebeest dot org> <CA+C-WL-PpwKHDDOic7HfNQygCGM6VjqeZRXVo_ZbNg+w+AmSRA at mail dot gmail dot com>

On Tue, Feb 10, 2015 at 06:15:44PM -0500, Patrick Palka wrote:
> Now that producer_is_gcc() returns a bool, shouldn't the statement
> 'return -1' become 'return false;', and the statement 'return major;'
> become 'return true;'?

Yes, of course. What a silly mistake. Thanks for catching that.

I pushed the attached as obvious.

Attachment: 0001-gdb-producer_is_gcc-fix-bool-return-value.patch
Description: Text document

References:
- Re: [PATCH] Merge GCC producer parsers. Allow digits in identifiers.
  - From: Mark Wielaard
- Re: [PATCH] Merge GCC producer parsers. Allow digits in identifiers.
  - From: Joel Brobecker
- Re: [PATCH] Merge GCC producer parsers. Allow digits in identifiers.
  - From: Mark Wielaard
- Re: [PATCH] Merge GCC producer parsers. Allow digits in identifiers.
  - From: Mark Wielaard
- Re: [PATCH] Merge GCC producer parsers. Allow digits in identifiers.
  - From: Patrick Palka

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]