This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PING] [PATCH 0/3] Fix for PR 17808 and some related changes


Ping:

  https://sourceware.org/ml/gdb-patches/2015-01/msg00424.html

Pedro commented already, as shown below.  Mark has not replied so far.

Note that the PR is on the TODO list for 7.9.  In my opinion at least
patch 1 should go in 7.9; it's fairly harmless and should fix the PR.
Patch 2 fixes a similar problem, but there might be a test gap, because
I currently don't have access to appropriate test hardware (with AVX and
AVX-512).  And with patch 3 there's a slight chance of introducing bogus
warnings when reading core files.  Thus I'd suggest to push all three
patches upstream, but only patch 1 into 7.9.  OK?

On Fri, Jan 23 2015, Pedro Alves wrote:

> On 01/15/2015 03:21 PM, Andreas Arnez wrote:
>> As seen in PR 17808, a test case with a forged (invalid) core file can
>> crash GDB with an assertion failure when a register section has the
>> wrong size.  This patch series is about improving GDB's behavior in
>> such cases: Patch 1 fixes the reported problem for i386 as well as for
>> other targets; patch 2 avoids out-of-bounds accesses when an x86
>> ".reg-xstate" section is too short, and patch 3 adds a warning when a
>> core file register section is larger than expected.
>> 
>> This is based on the "lazy approach" suggested here:
>> 
>>   https://sourceware.org/ml/gdb-patches/2015-01/msg00229.html
>> 
>> OK to apply?
>
> This looks good to me.  Mark, any comments?
>
> Thanks,
> Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]