This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] TUI: Expand TABs into spaces
- From: Doug Evans <xdje42 at gmail dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 16 Jan 2015 08:32:15 -0800
- Subject: Re: [PATCH] TUI: Expand TABs into spaces
- Authentication-results: sourceware.org; auth=none
- References: <83k3149k5b dot fsf at gnu dot org> <837fwn2cvc dot fsf at gnu dot org>
On Fri, Jan 16, 2015 at 3:17 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> Ping! OK to install, master and 7.9 branch?
>
>> Date: Sat, 03 Jan 2015 13:30:08 +0200
>> From: Eli Zaretskii <eliz@gnu.org>
>>
>> "gdb -tui" relies on the curses library and the underlying terminal
>> driver to expand TAB characters into spaces. But ncurses on Windows
>> doesn't do that, and instead displays an IBM graphics character.
>>
>> The patches below fix that in the command window and in displaying the
>> registers.
>>
>> OK to commit?
>>
>> 2015-01-03 Eli Zaretskii <eliz@gnu.org>
>>
>> * tui/tui-regs.c (tui_register_format): Expand TABs into the
>> appropriate number of spaces.
>>
>> * tui/tui-io.c (tui_puts, tui_redisplay_readline): Expand TABs
>> into the appropriate number of spaces.
I'd have to read the patch more to say it's ok,
but one thing that is missing are comments
explaining *why* we are expanding tabs into spaces.