This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Buildsym cleanups: more docs, more uniform set-up and tear-down
- From: Yao Qi <yao at codesourcery dot com>
- To: Doug Evans <xdje42 at gmail dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Mon, 15 Dec 2014 11:44:03 +0800
- Subject: Re: [PATCH] Buildsym cleanups: more docs, more uniform set-up and tear-down
- Authentication-results: sourceware.org; auth=none
- References: <m3a92rhyu0 dot fsf at seba dot sebabeach dot org>
Doug Evans <xdje42@gmail.com> writes:
Some comments on indentation.
> /* Restart compilation for a symtab.
> + CUST is the result of end_expandable_symtab.
> + NAME,START_ADDR are the source file we are resuming with.
Space after comma is missing.
>
> /* Subroutine of end_symtab_from_static_block to simplify it.
> Handle the "no blockvector" case.
> - When this happens there is nothing to record, so just free up
> - any memory we allocated while reading debug info. */
> + When this happens there is nothing to record, so there's nothing to do:
> + memory will be freed up later.
> + This function is kept to have a place to document the issues. */
>
> static void
> end_symtab_without_blockvector (void)
> {
> - /* Free up all the subfiles.
> - We won't be adding a compunit to the objfile's list of compunits,
> + /* Note: We won't be adding a compunit to the objfile's list of compunits,
> so there's nothing to unchain. However, since each symtab
> is added to the objfile's obstack we can't free that space.
> We could do better, but this is believed to be a sufficiently rare
> event. */
> - free_buildsym_compunit ();
> }
end_symtab_without_blockvector is empty, so remove it?
--
Yao (éå)