This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] remote-utils.c: remove unused gdb_stdlog
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Cleber Rosa <crosa at redhat dot com>
- Cc: gdb-patches at sourceware dot org, cleber at redhat dot com
- Date: Mon, 01 Dec 2014 15:34:37 -0500
- Subject: Re: [PATCH 1/2] remote-utils.c: remove unused gdb_stdlog
- Authentication-results: sourceware.org; auth=none
- References: <1417449499-23681-1-git-send-email-crosa at redhat dot com>
On Monday, December 01 2014, Cleber Rosa wrote:
> It looks like this came from an attempt to mimmic gdb/main.c, which
> has gdb_stdlog, gdb_stderr, gdb_stdout, etc. But in reality, it's
> not being used on gdbserver.
Heya :-).
Thanks for sending the patch upstream. As we have already discussed on
private, this looks almost obvious to me, but let's wait for some
maintainer to approve. Meanwhile...
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
We don't use Signed-off-by here, but it shouldn't do any harm to keep it
in the patch.
> ---
> gdb/gdbserver/ChangeLog | 4 ++++
> gdb/gdbserver/remote-utils.c | 1 -
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
> index e378a5f..0e110e7 100644
> --- a/gdb/gdbserver/ChangeLog
> +++ b/gdb/gdbserver/ChangeLog
> @@ -1,3 +1,7 @@
> +2014-12-01 Cleber Rosa <cleber@redhat.com>
> +
> + * remote-utils.c: Remove unused variable.
Every entry in the ChangeLog should be indented using TABs, and not
spaces. You could also specify *which* unused variable you are
removing. Thus:
* remote-utils.c: Remove unused variable "gdb_stdlog".
> +
> 2014-11-28 Yao Qi <yao@codesourcery.com>
>
> * configure.ac(AC_CHECK_FUNCS): Remove readlink.
> diff --git a/gdb/gdbserver/remote-utils.c b/gdb/gdbserver/remote-utils.c
> index 373fc15..442e94e 100644
> --- a/gdb/gdbserver/remote-utils.c
> +++ b/gdb/gdbserver/remote-utils.c
> @@ -100,7 +100,6 @@ struct sym_cache
> };
>
> int remote_debug = 0;
> -struct ui_file *gdb_stdlog;
>
> static int remote_is_stdio = 0;
>
> --
> 1.9.3
Thanks,
--
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/