This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 6/7] Use canonicalize_file_name unconditionally
- From: Yao Qi <yao at codesourcery dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Fri, 28 Nov 2014 18:43:19 +0800
- Subject: Re: [PATCH 6/7] Use canonicalize_file_name unconditionally
- Authentication-results: sourceware.org; auth=none
- References: <1416980800-21408-1-git-send-email-yao at codesourcery dot com> <1416980800-21408-7-git-send-email-yao at codesourcery dot com> <20141127073600 dot GA5042 at adacore dot com> <87r3woc9aw dot fsf at codesourcery dot com> <20141128034300 dot GH5042 at adacore dot com>
Joel Brobecker <brobecker@adacore.com> writes:
> Given how frequent it is for source files to be unavailable,
> I would say that it would be useful to preserve the GetFullPathName
> behavior for those files as well, and allow users to set breakpoints
> without having to worry about how many backslashes GCC has been
> using. Or said differently, I agree with your decision :-).
>
> I am taking a note to:
>
> 1. Add an extra comment to this part of the code once you've pushed
> your patch;
>
> 2. Double-check what newer versions of GCC do. At some point, perhaps
> we can declare a minimum GCC version that we fully support and
> then mark this code area for possible removal if it ever starts
> causing extra work.
Great, I've pushed them in.
--
Yao (éå)