This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/7 V2] Import the rename gnulib module
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 27 Nov 2014 11:41:13 +0400
- Subject: Re: [PATCH 0/7 V2] Import the rename gnulib module
- Authentication-results: sourceware.org; auth=none
- References: <1416980800-21408-1-git-send-email-yao at codesourcery dot com>
> This patch series is to import rename gnulib module and other
> dependent modules. We need rename module to fix some
> fileio.exp fails on mingw32 host, on which the errno setting
> isn't compliance with POSIX. V1 can be found
> https://sourceware.org/ml/gdb-patches/2014-10/msg00837.html
>
> rename module depends on readlink, lstat and canonicalize-lgpl modules,
> and they are used by GDB too, so this patch series imports them
> explicitly and use them. Patches 1, 3, and 5 import readlink,
> lstat and canonicalize-lgpl respectively. Patches 2, 4, and 6
> are to use these api unconditionally. Patch 7 is about importing
> rename module.
>
> Regression tested on x86_64-linux and arm-eabi both on linux host
> ahd mingw32 host. Two fails in fileio.exp on mingw32 host are
> fixed.
I skimmed through the patch set, and didn't any problem
(one question, but not blocking).
Thanks for doing this, Yao. I agree it helps making our codebase
slightly more straightforward.
--
Joel