This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix MPX and AVX512 tests for path changes.
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Walfred Tedeschi <walfred dot tedeschi at intel dot com>
- Cc: palves at redhat dot com, mark dot kettenis at xs4all dot nl, gdb-patches at sourceware dot org
- Date: Sun, 23 Nov 2014 07:42:12 +0400
- Subject: Re: [PATCH] Fix MPX and AVX512 tests for path changes.
- Authentication-results: sourceware.org; auth=none
- References: <1412062097-22417-1-git-send-email-walfred dot tedeschi at intel dot com>
Hello Walfred,
On Tue, Sep 30, 2014 at 09:28:17AM +0200, Walfred Tedeschi wrote:
> Changes on the path for i386-cpuid.h file lead to failure in compiling
> tests for MPX and AVX512. Conformity between both tests is also
> addressed with this path.
>
> 2014-08-12 Walfred Tedeschi <walfred.tedeschi@intel.com>
>
> gdb/testsuite
> * gdb.arch/i386-avx512.c: Change path in include file.
> * gdb.arch/i386-mpx.c: Change path in include file.
> * gdb.arch/i386-avx512.exp: Change include dir path
> compilation flag.
> * gdb.arch/i386-mpx.exp: Change include dir path
> compilation flag.
Overall, the changes look good. But would you mind please splitting
this patch into individual pieces. For instance, one patch to fix
i386-avx512.exp's build failure, one patch to fix i386-mpx.exp's
build failure, and then as many individual patches for the other
changes made for "conformity between both tests". I am 300 patches
behind on review and trying to spend this weekend catching up a bit,
so a more detailed explanation will help me, as well as anyone
going back in time trying to figure out why some changes were made.
Thank you!
--
Joel