This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/7] Include alloca.h unconditionally
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 21 Nov 2014 13:17:10 +0000
- Subject: Re: [PATCH 3/7] Include alloca.h unconditionally
- Authentication-results: sourceware.org; auth=none
- References: <1416057612-16155-1-git-send-email-yao at codesourcery dot com> <1416057612-16155-4-git-send-email-yao at codesourcery dot com> <546F2E3E dot 50504 at redhat dot com> <87bno0g0vl dot fsf at codesourcery dot com>
On 11/21/2014 01:05 PM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>>> -#ifdef HAVE_ALLOCA_H
>>> -#include <alloca.h>
>>> -#endif
>>> /* On some systems such as MinGW, alloca is declared in malloc.h
>>> (there is no alloca.h). */
>>> #if HAVE_MALLOC_H
>>
>> We should remove the malloc.h includes too then, and the check
>> for malloc.h in configure.ac. It's only included for alloca.
>
> That is a good point. The patch below is to do so.
Thanks. This version looks good to me.
Pedro Alves