This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 02/12] btrace: add format argument to supports_btrace
- From: Pedro Alves <palves at redhat dot com>
- To: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 14 Nov 2014 13:36:46 +0000
- Subject: Re: [PATCH 02/12] btrace: add format argument to supports_btrace
- Authentication-results: sourceware.org; auth=none
- References: <1405346196-1804-1-git-send-email-markus dot t dot metzger at intel dot com> <1405346196-1804-3-git-send-email-markus dot t dot metzger at intel dot com> <545A8C5B dot 3040504 at redhat dot com> <A78C989F6D9628469189715575E55B231E673C5C at IRSMSX104 dot ger dot corp dot intel dot com>
On 11/14/2014 12:36 PM, Metzger, Markus T wrote:
>> From: Pedro Alves [mailto:palves@redhat.com]
>>> +/* Target specific branch trace information. */
>>> +struct btrace_target_info;
>>> +
>>> +/* Enumeration of btrace read types. */
>>> +
>>> +enum btrace_read_type
>>> +{
>>> + /* Send all available trace. */
>>> + BTRACE_READ_ALL,
>>> +
>>> + /* Send all available trace, if it changed. */
>>> + BTRACE_READ_NEW,
>>> +
>>> + /* Send the trace since the last request. This will fail if the trace
>>> + buffer overflowed. */
>>> + BTRACE_READ_DELTA
>>> +};
>>
>> What does "Send" mean here?
>
> It means as much as "read". It determines what trace you'll get
> when reading btrace.
> I realize it's the producer's view; it should rather be the consumer's
> view.
Ah, yeah.
> Do you want me to change it in a separate patch?
Hmm, I'm confused -- why a separate patch instead of simply
adjusting this one?
Thanks,
Pedro Alves