This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 07/12] btrace: extend struct btrace_insn
- From: Pedro Alves <palves at redhat dot com>
- To: Markus Metzger <markus dot t dot metzger at intel dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 05 Nov 2014 20:46:19 +0000
- Subject: Re: [PATCH 07/12] btrace: extend struct btrace_insn
- Authentication-results: sourceware.org; auth=none
- References: <1405346196-1804-1-git-send-email-markus dot t dot metzger at intel dot com> <1405346196-1804-8-git-send-email-markus dot t dot metzger at intel dot com>
On 07/14/2014 02:56 PM, Markus Metzger wrote:
> +static enum btrace_insn_class
> +ftrace_classify_insn (struct gdbarch *gdbarch, CORE_ADDR pc)
Missing intro comment.
> +{
> + volatile struct gdb_exception error;
> + enum btrace_insn_class iclass;
> +
> + iclass = BTRACE_INSN_OTHER;
> + TRY_CATCH (error, RETURN_MASK_ALL)
This swallows ctrl-c. I think it should be RETURN_MASK_ERROR.
Likewise other TRY_CATCH uses.
> + {
Thanks,
Pedro Alves