RE: [PATCH 00/12] record btrace: prepare for a new trace format

["Metzger, Markus T" <markus dot t dot metzger at intel dot com>]

Hello Pedro, Maintainers,

Any feedback to this series?

Here are links to the original emails:
https://sourceware.org/ml/gdb-patches/2014-07/msg00322.html
https://sourceware.org/ml/gdb-patches/2014-07/msg00334.html
https://sourceware.org/ml/gdb-patches/2014-07/msg00324.html
https://sourceware.org/ml/gdb-patches/2014-07/msg00329.html
https://sourceware.org/ml/gdb-patches/2014-07/msg00330.html
https://sourceware.org/ml/gdb-patches/2014-07/msg00333.html
https://sourceware.org/ml/gdb-patches/2014-07/msg00325.html
https://sourceware.org/ml/gdb-patches/2014-07/msg00328.html
https://sourceware.org/ml/gdb-patches/2014-07/msg00326.html
https://sourceware.org/ml/gdb-patches/2014-07/msg00323.html
https://sourceware.org/ml/gdb-patches/2014-07/msg00331.html
https://sourceware.org/ml/gdb-patches/2014-07/msg00327.html
https://sourceware.org/ml/gdb-patches/2014-07/msg00332.html

The patches don't apply anymore.  I can send an updated patch
series if that's requested.  There are no changes besides resolving
merge conflicts except for:

The kernel interface changed meanwhile which affects:
    btrace, linux: add perf event buffer abstraction
    [wip] btrace: support Intel(R) Processor Trace

I have updates for those, as well, if someone wants to try out the
patches together with an experimental kernel.

Thanks,
Markus.

> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Markus Metzger
> Sent: Monday, July 14, 2014 3:56 PM
> To: palves@redhat.com
> Cc: gdb-patches@sourceware.org
> Subject: [PATCH 00/12] record btrace: prepare for a new trace format
> 
> This is the first part of a patch series that adds support for a new trace
> format.  The entire series consists of three parts:
> 
>   - preparation (this)
>   - support live inferior tracing
>   - support trace in core files
> 
> 
> Besides preparing for an additional trace format, this first part adds the
> following functionality:
> 
>   - allow the trace buffer size to be configured
>   - indicate errors as gaps in the trace
> 
> 
> In order to motivate some patches (e.g. identifying the cpu or changing the
> btrace_compute_ftrace parameters), I also send a work-in-progress version
> of the
> second part that adds support for the new trace format.  This patch is not
> part
> of the series under review.
> 
> 
> Markus Metzger (12):
>   btrace: add struct btrace_data
>   btrace: add format argument to supports_btrace
>   btrace, linux: add perf event buffer abstraction
>   record btrace: add configuration struct
>   record-btrace: add bts buffer size configuration option
>   btrace: update btrace_compute_ftrace parameters
>   btrace: extend struct btrace_insn
>   btrace: identify cpu
>   btrace: use the new cpu identifier
>   record-btrace: indicate gaps
>   configure: check for libipt
>   [wip] btrace: support Intel(R) Processor Trace
> 
>  gdb/Makefile.in                                  |  16 +-
>  gdb/NEWS                                         |  37 +
>  gdb/btrace.c                                     | 965 ++++++++++++++++++++---
>  gdb/btrace.h                                     |  98 ++-
>  gdb/common/btrace-common.c                       | 175 ++++
>  gdb/common/btrace-common.h                       | 242 +++++-
>  gdb/config.in                                    |   3 +
>  gdb/configure                                    | 498 ++++++++++++
>  gdb/configure.ac                                 |  20 +
>  gdb/doc/gdb.texinfo                              | 189 ++++-
>  gdb/features/btrace-conf.dtd                     |  17 +
>  gdb/features/btrace.dtd                          |  18 +-
>  gdb/gdbserver/Makefile.in                        |   8 +-
>  gdb/gdbserver/linux-low.c                        | 181 ++++-
>  gdb/gdbserver/server.c                           | 228 +++++-
>  gdb/gdbserver/target.h                           |  27 +-
>  gdb/nat/linux-btrace.c                           | 806 ++++++++++++++++---
>  gdb/nat/linux-btrace.h                           |  79 +-
>  gdb/record-btrace.c                              | 497 +++++++++++-
>  gdb/remote.c                                     | 233 +++++-
>  gdb/target-delegates.c                           |  32 +-
>  gdb/target.c                                     |  22 +-
>  gdb/target.h                                     |  37 +-
>  gdb/testsuite/gdb.btrace/buffer-size.exp         |  57 ++
>  gdb/testsuite/gdb.btrace/delta.exp               |  12 +-
>  gdb/testsuite/gdb.btrace/enable.exp              |   4 +-
>  gdb/testsuite/gdb.btrace/finish.exp              |   3 +-
>  gdb/testsuite/gdb.btrace/instruction_history.exp |   2 +-
>  gdb/testsuite/gdb.btrace/next.exp                |   6 +-
>  gdb/testsuite/gdb.btrace/nexti.exp               |   6 +-
>  gdb/testsuite/gdb.btrace/nohist.exp              |   3 +-
>  gdb/testsuite/gdb.btrace/step.exp                |   6 +-
>  gdb/testsuite/gdb.btrace/stepi.exp               |   6 +-
>  gdb/x86-linux-nat.c                              |  18 +-
>  34 files changed, 4143 insertions(+), 408 deletions(-)
>  create mode 100644 gdb/common/btrace-common.c
>  create mode 100644 gdb/features/btrace-conf.dtd
>  create mode 100644 gdb/testsuite/gdb.btrace/buffer-size.exp
> 
> --
> 1.8.3.1

Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052