This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[COMMITTED PATCH] allocate_block: Use OBSTACK_ZALLOC.
- From: Doug Evans <xdje42 at gmail dot com>
- To: gdb-patches at sourceware dot org
- Date: Sun, 26 Oct 2014 11:40:56 -0700
- Subject: [COMMITTED PATCH] allocate_block: Use OBSTACK_ZALLOC.
- Authentication-results: sourceware.org; auth=none
Hi.
I noticed this while reading block.c.
allocate_block does this:
struct block *
allocate_block (struct obstack *obstack)
{
struct block *bl = obstack_alloc (obstack, sizeof (struct block));
BLOCK_START (bl) = 0;
BLOCK_END (bl) = 0;
BLOCK_FUNCTION (bl) = NULL;
BLOCK_SUPERBLOCK (bl) = NULL;
BLOCK_DICT (bl) = NULL;
BLOCK_NAMESPACE (bl) = NULL;
return bl;
}
whereas allocate_global_block does this:
struct block *
allocate_global_block (struct obstack *obstack)
{
struct global_block *bl = OBSTACK_ZALLOC (obstack, struct global_block);
return &bl->block;
}
To keep these consistent and simple, I've committed this:
2014-10-26 Doug Evans <xdje42@gmail.com>
* block.c (allocate_block): Use OBSTACK_ZALLOC instead of
obstack_alloc.
diff --git a/gdb/block.c b/gdb/block.c
index 4a31ea9..8d40c9d 100644
--- a/gdb/block.c
+++ b/gdb/block.c
@@ -373,14 +373,7 @@ block_global_block (const struct block *block)
struct block *
allocate_block (struct obstack *obstack)
{
- struct block *bl = obstack_alloc (obstack, sizeof (struct block));
-
- BLOCK_START (bl) = 0;
- BLOCK_END (bl) = 0;
- BLOCK_FUNCTION (bl) = NULL;
- BLOCK_SUPERBLOCK (bl) = NULL;
- BLOCK_DICT (bl) = NULL;
- BLOCK_NAMESPACE (bl) = NULL;
+ struct block *bl = OBSTACK_ZALLOC (obstack, struct block);
return bl;
}