This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/9] Adapt `info probes' to support printing probes of different types.
- From: jose dot marchesi at oracle dot com (Jose E. Marchesi)
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 10 Oct 2014 18:36:20 +0200
- Subject: Re: [PATCH 1/9] Adapt `info probes' to support printing probes of different types.
- Authentication-results: sourceware.org; auth=none
- References: <1411724905-31234-1-git-send-email-jose dot marchesi at oracle dot com> <1411724905-31234-2-git-send-email-jose dot marchesi at oracle dot com> <87d2ae9lh2 dot fsf at redhat dot com>
Hi Sergio.
> A "probe type" (backend for the probe abstraction implemented in probe.[ch])
> can extend the information printed by `info probes' by defining additional
> columns. This means that when `info probes' is used to print all the probes
> regardless of their types, some of the columns will be "not applicable" to
> some of the probes (like, say, the Semaphore column only makes sense for
> SystemTap probes). This patch makes `info probes' fill these slots with "n/a"
> marks (currently it breaks the table) and not include headers for which no
> actual probe has been found in the list of defined probes.
Thanks for the patch, Jose. Comments below.
I agree/comply with all these comments :)