This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Stabs: Ignore N_BNSYM/N_ENSYM entry types
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 3 Oct 2014 06:40:16 -0700
- Subject: Re: [RFA] Stabs: Ignore N_BNSYM/N_ENSYM entry types
- Authentication-results: sourceware.org; auth=none
- References: <000301cfde29$fdfe98a0$f9fbc9e0$ at muller@ics-cnrs.unistra.fr> <20141002181805 dot GH6927 at adacore dot com> <00b601cfdedc$9314d0a0$b93e71e0$ at muller@ics-cnrs.unistra.fr>
> This is my first push since we switched to git... And I must
> confess that I did not read the whole thread about commit log
> messages...
The wiki tries to describe a bit how revision logs should be formatted.
See Item #13 of https://sourceware.org/gdb/wiki/ContributionChecklist
> So in:
> https://sourceware.org/ml/gdb-cvs/2014-10/msg00015.html
>
> I've put essentially the email of my RFA, with just two modifications:
>
> I removed the gdb/ prefix in the ChangeLog and updated the date to
> 2014-10-03.
I tend to work the other way around: I put in the commit's revision
log the explanation of the bug following the format described in
the wiki, and that use that as the basis for the email sent to
gdb-patches. In fact, I use git to do the email-sending for me
(git send-email), and the only touch-ups I usually do is just to
add "Hello" and "Thank you/OK to commit" (etc).
So, when the patch is OK to go in, all that is needed is to push.
I don't need to re-write the revision log.
--
Joel