This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Don't prune program spaces when doing "maintenance info program-spaces"
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Wed, 24 Sep 2014 15:31:40 -0400
- Subject: Re: [PATCH] Don't prune program spaces when doing "maintenance info program-spaces"
- Authentication-results: sourceware.org; auth=none
- References: <1411582288-20967-1-git-send-email-simon dot marchi at ericsson dot com> <87h9zwn93k dot fsf at redhat dot com>
On 2014-09-24 02:53 PM, Sergio Durigan Junior wrote:
>> @@ -385,7 +386,7 @@ maintenance_info_program_spaces_command (char *args, int from_tty)
>> error (_("program space ID %d not known."), requested);
>> }
>>
>> - print_program_space (current_uiout, requested);
>> + print_program_space (current_uiout, requested, 0 /* prune */);
>
> Just like we had a comment explaining why we were pruning progspaces, I
> think a small comment here explaining why we are *not* pruning them
> would be neat.
Sure, I could add to the current patch, above the call to print_program_space:
/* Since this is an "info" command, we want to avoid modifying
the state of the debugger. Therefore, don't prune unused
program spaces. */