This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3 2/2] Add dprintf and detach test (PR breakpoints/17012)
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Fri, 05 Sep 2014 16:41:44 +0100
- Subject: Re: [PATCH v3 2/2] Add dprintf and detach test (PR breakpoints/17012)
- Authentication-results: sourceware.org; auth=none
- References: <1408734315-21207-1-git-send-email-simon dot marchi at ericsson dot com> <1408734315-21207-2-git-send-email-simon dot marchi at ericsson dot com> <54089744 dot 2030702 at redhat dot com> <5408B159 dot 20203 at ericsson dot com>
On 09/04/2014 07:37 PM, Simon Marchi wrote:
> On 14-09-04 12:45 PM, Pedro Alves wrote:
>> On 08/22/2014 08:05 PM, Simon Marchi wrote:
>>
>>
>>> Until the remote case is sorted out, would it be ok to disable the
>>> test for all remote targets or KFAIL the tests? I will tackle the
>>> blocking problems in separate patches.
>>
>> Sure.
>
> I am not sure how to do this though. Is this ok?
Looks like it. Alternatively, you can use setup_kfail
and always do the re-attach.
>
> # Disable this test when using gdb for now (the inferior crashes when
> # detaching due to PR 17302).
> set test "re-attach to inferior"
> if ![gdb_is_target_remote] {
> # Give some time for the ex-inferior to run and hopefully not crash.
> sleep 1
>
> gdb_test "attach $inferior_pid" "Attaching to program: $escapedbinfile, process $inferior_pid.*Reading symbols from.*" "$test"
> } else {
> kfail "breakpoints/17302" "$test"
"server/17302"
> }
>
> I know that "remote" does not necessarily means gdbserver, but I don't
> know how to check for gdbserver specifically.
There's a check in qtro.exp you could reuse. See "probe for GDBserver".
Thanks,
Pedro Alves