This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix the processing of Meta-key commands in TUI
- From: Pedro Alves <palves at redhat dot com>
- To: Patrick Palka <patrick at parcs dot ath dot cx>, gdb-patches at sourceware dot org
- Date: Thu, 28 Aug 2014 12:31:11 +0100
- Subject: Re: [PATCH] Fix the processing of Meta-key commands in TUI
- Authentication-results: sourceware.org; auth=none
- References: <1408740286-29326-1-git-send-email-patrick at parcs dot ath dot cx>
On 08/22/2014 09:44 PM, Patrick Palka wrote:
> +
> + if (async_command_editing_p && key_is_start_sequence (ch))
I think the key_is_start_sequence check means that we'll
fail to compensate in case the sequence if longer than
2 bytes? That is, we'll compensate for the second char,
but fail to compensate for the third, because by then,
ch will not be a start sequence key.
> + {
> + int ch_pending;
> +
> + nodelay (w, TRUE);
> + ch_pending = wgetch (w);
> + nodelay (w, FALSE);
> +
Thanks,
Pedro Alves