Re: [PATCH 4/5 v7] Introduce common-debug.h

[Gary Benson <gbenson at redhat dot com>]

Frank Ch. Eigler wrote:
> > > [...]
> > > i'm fine with updating sim/common/sim-trace.h with that idea:
> > > #define debug_printf sim_debug_printf
> > > all the symbols coming out of the sim really should be namespaced
> 
> IMHO, names this generic should be avoided in *both* application (gdb)
> and library (sim), lest another future library come & interfere later.

Yeah, I should know this by now :/

> > Great.  I can put together a patch if you like (or I can make the
> > change, or you can... whatever's easiest!)  I don't know much about
> > SIM... is there a list to mail patches to?  And, is its upstream
> > repo the same as binutils+GDB or is it imported from somewhere else
> > like libiberty?
> 
> sim is part of the binutils-gdb.git repo, patches here fine.  The
> main problem with testing the sim for changes like this is its
> inability to easily build all targets, and its aggressive use of
> macros, which makes it hard to know you've actually covered all the
> cases for a symbol-rename.

Yuck :(

Frank, if you're not ok with the patch I just mailed then let me know
and I'll figure something out when I get back from PTO.

Thanks,
Gary

-- 
http://gbenson.net/