This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/6] Convert fatal to error in remote_prepare
- From: Pedro Alves <palves at redhat dot com>
- To: Gary Benson <gbenson at redhat dot com>, gdb-patches at sourceware dot org
- Date: Wed, 20 Aug 2014 17:19:44 +0100
- Subject: Re: [PATCH 4/6] Convert fatal to error in remote_prepare
- Authentication-results: sourceware.org; auth=none
- References: <1407340688-13721-1-git-send-email-gbenson at redhat dot com> <1407340688-13721-5-git-send-email-gbenson at redhat dot com>
On 08/06/2014 04:58 PM, Gary Benson wrote:
> This commit converts a call to fatal in remote_prepare with a call to
> error. remote_prepare is called precisely once, from main, at a point
> where jumping to toplevel will call exit (1), so error and fatal are
> functionally equivalent at this point. Note that remote_prepare calls
> perror_with_name (which calls error) so callers of remote_prepare must
> already handle the fact that it may exit via longjmp.
>
> gdb/gdbserver/
> 2014-08-06 Gary Benson <gbenson@redhat.com>
>
> * remote-utils.c (remote_prepare): Replace fatal with error.
OK.
Thanks,
Pedro Alves