This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 06/11 v5] Add target/symbol.h
- From: Gary Benson <gbenson at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Doug Evans <dje at google dot com>
- Date: Wed, 20 Aug 2014 13:14:03 +0100
- Subject: Re: [PATCH 06/11 v5] Add target/symbol.h
- Authentication-results: sourceware.org; auth=none
- References: <1406888377-25795-1-git-send-email-gbenson at redhat dot com> <1406888377-25795-7-git-send-email-gbenson at redhat dot com> <53F48372 dot 2080703 at redhat dot com>
Pedro Alves wrote:
> On 08/01/2014 11:19 AM, Gary Benson wrote:
> > This adds target/symbol.h. This file declares a function that the
> > shared code can use and that the clients must implement. It also
> > changes some shared code to use these functions.
>
> A small parens:
>
> I have to say that calling this new method target_foo looks kind
> of awkward to me. Unlike other target methods and helpers, that
> extract info out of the target or tell the target to do something,
> this goes in the other direction -- this is the target/backend/
> server calling back to the client/symbol side for something. Put
> another way, seems like this method would never ultimately go
> through target_ops.
Can you suggest a more suitable name?
Thanks,
Gary
--
http://gbenson.net/