This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 PR c++/17132] Add new argument NOSIDE to find_overload_match
- From: Doug Evans <dje at google dot com>
- To: Siva Chandra <sivachandra at google dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Thu, 14 Aug 2014 15:38:22 -0700
- Subject: Re: [PATCH v2 PR c++/17132] Add new argument NOSIDE to find_overload_match
- Authentication-results: sourceware.org; auth=none
- References: <CAGyQ6gzQUgPQz1fUXes7Z_q6nMx7XCGNK4kUrrNfqW+80Djezw at mail dot gmail dot com>
Siva Chandra writes:
> The attached patch has been updated per Doug's suggestions.
>
> Original post: https://sourceware.org/ml/gdb-patches/2014-07/msg00197.html
> Doug's review comments:
> https://sourceware.org/ml/gdb-patches/2014-08/msg00055.html
>
> ChangeLog:
>
> 2014-08-14 Siva Chandra Reddy <sivachandra@google.com>
>
> gdb/
>
> * eval.c: Update all calls to find_overload_match.
> * valarith.c: Likewise.
> (value_user_defined_cpp_op, value_user_defined_op): New
> argument NOSIDE. Update all callers.
> * valops.c (find_overload_match): New argument NOSIDE.
> * value.h (find_overload_match): Update signature.
>
> gdb/testsuite
>
> * gdb.cp/pr17132.cc: New file.
> * gdb.cp/pr17132.exp: New file.
LGTM