This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 04/11 v5] Introduce and use debug_printf and debug_vprintf
- From: Gary Benson <gbenson at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches at sourceware dot org, Pedro Alves <palves at redhat dot com>, Tom Tromey <tromey at redhat dot com>
- Date: Thu, 7 Aug 2014 10:22:50 +0100
- Subject: Re: [PATCH 04/11 v5] Introduce and use debug_printf and debug_vprintf
- Authentication-results: sourceware.org; auth=none
- References: <1406888377-25795-1-git-send-email-gbenson at redhat dot com> <1406888377-25795-5-git-send-email-gbenson at redhat dot com> <21474 dot 24819 dot 964899 dot 502265 at ruffy dot mtv dot corp dot google dot com>
Doug Evans wrote:
> Gary Benson writes:
> > +/* A stdarg wrapper for debug_vprintf. */
> > +
> > +static void ATTRIBUTE_PRINTF (1, 2)
> > +debug_agent_print (const char *fmt, ...)
>
> Nit: debug_agent_printf ?
I will change this.
> > +/* Print a formatted message to the appropriate channel for debugging
> > + output for the client. */
>
> IWBN to include mention that this function must be provided by the client.
> [I'm not sure what other similar decls do, but IWBN if they all had
> a similar comment.]
That's a good idea. I'll add this here and everywhere else that needs
it.
Thanks,
Gary
--
http://gbenson.net/