This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 08/11 v5] Include common-defs.h instead of defs.h/server.h in shared code
- From: Doug Evans <dje at google dot com>
- To: Gary Benson <gbenson at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Pedro Alves <palves at redhat dot com>, Tom Tromey <tromey at redhat dot com>
- Date: Wed, 6 Aug 2014 11:16:32 -0700
- Subject: Re: [PATCH 08/11 v5] Include common-defs.h instead of defs.h/server.h in shared code
- Authentication-results: sourceware.org; auth=none
- References: <1406888377-25795-1-git-send-email-gbenson at redhat dot com> <1406888377-25795-9-git-send-email-gbenson at redhat dot com>
Gary Benson writes:
> This commit makes 19 of the 22 shared .c files in common, nat and
> target include common-defs.h instead of defs.h/server.h. The
> remaining three files need slight extra work and are dealt with
> in separate commits.
>
> gdb/
> 2014-08-01 Gary Benson <gbenson@redhat.com>
>
> * common/agent.c: Include common-defs.h.
> Don't include defs.h or server.h.
> * common/buffer.c: Likewise.
> * common/common-debug.c: Likewise.
> * common/common-utils.c: Likewise.
> * common/errors.c: Likewise.
> * common/filestuff.c: Likewise.
> * common/format.c: Likewise.
> * common/gdb_vecs.c: Likewise.
> * common/print-utils.c: Likewise.
> * common/ptid.c: Likewise.
> * common/rsp-low.c: Likewise.
> * common/signals.c: Likewise.
> * common/vec.c: Likewise.
> * common/xml-utils.c: Likewise.
> * nat/linux-osdata.c: Likewise.
> * nat/linux-procfs.c: Likewise.
> * nat/linux-ptrace.c: Likewise.
> * nat/mips-linux-watch.c: Likewise.
> * target/waitstatus.c: Likewise.
LGTM