This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: MSP430 SIM: Add support for hardware multiply


On Thu 08 May 2014 08:52:49 Nick Clifton wrote:
>   I am applying the attached patch to add support for simulating the
>   hardware multiply feature found on some MSP430 MCUs.

any reason for the compression ?  its size doesn't seem to justify it at all.

> sim/msp430/ChangeLog
> 2014-05-08  Nick Clifton  <nickc@redhat.com>
> 
> 	* msp430-sim.c (sim_open): Do not allocate memory over the
> 	hardware multiply registers.
> 	(get_op): Add support for reads from the hardware multiply
> 	registers.
> 	(put_op): Add support for writes to the hardware multiply
> 	registers.
> 	(msp430_step_once): Add support for the RETI instruction used by
> 	the CPUX architecture.

the global static vars really look like they should be part of the cpu or sim 
state and not just global variables.  otherwise you can't easily reset them ?
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]