This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 0/4] baby step toward multi-target


Tom> If this approach seems reasonable then it's not too hard to pull over
Tom> some of the other target conversions from the branch.

Pedro> Seems reasonable.  We may or not end up doing things completely
Pedro> different wrt to the identify issue and target is pushed/not pushed,
Pedro> but meanwhile this lets us progress with making it possible to have
Pedro> different instances of a target, so it seems good forward progress.

Pedro> The series looked good to me.

Thanks for looking.

I actually went a bit farther down this path on my branch, adding:

    0249cca turn remote into a to_xclose target
    84e2677 turn linux-thread-db into a to_xclose target
    9fdaa64 fix exec_close to be multi-target-aware
    7fd03ff introduce the target stack
    698a56f convert current_target to be a pointer
    68520c8 convert exec target to to_xclose

These are all things pulled over from the mostly-defunct multi-target
branch.

I probably wouldn't be inclined to put these -- or maybe even the bulk
of the "baby step" series -- in right now.  They aren't really that
useful until some other things are finished, like adding the target ID
to ptid.

However, it's probably useful as a starting point for the next attempt
at multi-target.  In particular it's much less invasive than the earlier
approach, and the "convert current_target to be a pointer" patch (the
biggest one) was mostly done with a perl one-liner.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]