This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Re: Regression for GDB global --statistics
- From: Doug Evans <dje at google dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Jan Kratochvil <jan dot kratochvil at redhat dot com>, Eli Zaretskii <eliz at gnu dot org>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Thu, 17 Jul 2014 12:55:12 +0100
- Subject: Re: [PATCH] Re: Regression for GDB global --statistics
- Authentication-results: sourceware.org; auth=none
- References: <yjt2ip4s5mbu dot fsf at ruffy2 dot mtv dot corp dot google dot com> <20140630171333 dot GA2225 at host2 dot jankratochvil dot net> <21437 dot 45024 dot 997531 dot 453750 at ruffy dot mtv dot corp dot google dot com> <53BEC275 dot 8000004 at redhat dot com> <21440 dot 24455 dot 769287 dot 540494 at ruffy dot mtv dot corp dot google dot com> <53C4F655 dot 2040708 at redhat dot com>
On Tue, Jul 15, 2014 at 10:37 AM, Pedro Alves <palves@redhat.com> wrote:
> On 07/11/2014 11:04 PM, Doug Evans wrote:
>> Pedro Alves writes:
>
>> > It's not obvious to me how this can be NULL, given we initialize
>> > it so early. If there's a good reason, could you please add
>> > a comment here mentioning it?
>
> ...
>
>> - ALL_SYMTABS (o, s)
>> + /* When collecting statistics during startup, this is called before
>> + pretty much anything in gdb has been initialized, and thus
>> + current_program_space may be NULL. */
>> + if (current_program_space != NULL)
>
> Great, thanks!
>
> --
> Pedro Alves
Apologies for the repeat (note to self: try to remember to not send
email to list from phone).
Committed to trunk and 7.8.
Jan: Please commit your testcase (no point in resending both messages, bleah).