This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 03/15] Make gdbserver CORE_ADDR unsigned
- From: Doug Evans <dje at google dot com>
- To: Gary Benson <gbenson at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 11 Jul 2014 12:30:36 -0700
- Subject: Re: [PATCH 03/15] Make gdbserver CORE_ADDR unsigned
- Authentication-results: sourceware.org; auth=none
- References: <1404902255-11101-1-git-send-email-gbenson at redhat dot com> <1404902255-11101-4-git-send-email-gbenson at redhat dot com>
Gary Benson writes:
> gdbserver defines CORE_ADDR to be signed. This seems erroneous to
> me; and furthermore likely to cause problems in common/, as it is
> different from gdb's definition.
>
> gdb/gdbserver/
> 2014-07-09 Tom Tromey <tromey@redhat.com>
>
> * defs.h (CORE_ADDR): Now unsigned.
> ---
> gdb/gdbserver/ChangeLog | 4 ++++
> gdb/gdbserver/server.h | 2 +-
> 2 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/gdb/gdbserver/server.h b/gdb/gdbserver/server.h
> index 6eb1a16..2d55513 100644
> --- a/gdb/gdbserver/server.h
> +++ b/gdb/gdbserver/server.h
> @@ -87,7 +87,7 @@ typedef unsigned char gdb_byte;
>
> /* FIXME: This should probably be autoconf'd for. It's an integer type at
> least the size of a (void *). */
> -typedef long long CORE_ADDR;
> +typedef unsigned long long CORE_ADDR;
>
> typedef long long LONGEST;
> typedef unsigned long long ULONGEST;
> --
> 1.7.1
>
LGTM, modulo file name spelled wrong in changelog entry.