This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 07/15] Remove GDBSERVER use from nat/i386-dregs.c
- From: Gary Benson <gbenson at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 11 Jul 2014 13:53:06 +0100
- Subject: Re: [PATCH 07/15] Remove GDBSERVER use from nat/i386-dregs.c
- Authentication-results: sourceware.org; auth=none
- References: <1404902255-11101-1-git-send-email-gbenson at redhat dot com> <1404902255-11101-8-git-send-email-gbenson at redhat dot com> <87k37ldrz4 dot fsf at fleche dot redhat dot com>
Tom Tromey wrote:
> >>>>> "Gary" == Gary Benson <gbenson@redhat.com> writes:
>
> Gary> This removes the use of GDBSERVER from nat/i386-dregs.c.
> Gary> Neither defs.h or server.h are included: the specific files
> Gary> required are listed instead. Also, a declaration previously
> Gary> made only outside of gdbserver is made unconditional.
>
> Gary> -#ifdef GDBSERVER
> Gary> -#include "server.h"
> Gary> -#else
> Gary> -#include "defs.h"
> Gary> -#include "inferior.h"
> Gary> -#endif
> Gary> +#include "common-utils.h"
>
> I think this should include config.h first.
common-utils.h includes it. Or did you mean the gnulib one?
Thanks,
Gary
--
http://gbenson.net/